Re: [PATCH/RFC] remove len/ooblen confusion in MTD/NAND code: respin

[Artem Bityutskiy <dedekind@infradead.org>]

Hello Vitaly,
On Fri, 2006-11-03 at 18:20 +0300, Vitaly Wool wrote:
> Hello folks,
> 
> as was discussed between Ricard Wanderlof, David Woodhouse, Artem Bityutskiy and me, the current API for reading/writing OOB is confusing. The thing that introduces confusion is the need to specify ops.len together with ops.ooblen for reads/writes that concern only OOB not data area. So, ops.len is overloaded: when ops.datbuf != NULL it serves to specify the length of the data read, and when ops.datbuf == NULL, it serves to specify the full OOB read length.
> The patch inlined below is the slightly updated version of the previous patch serving the same purpose, but with the new Artem's comments taken into account.
> Artem, BTW, thanks a lot for your valuable input!

this patch does not apply to mtd-2.6.git:

patching file drivers/mtd/inftlcore.c
patching file drivers/mtd/nand/nand_base.c
Hunk #2 succeeded at 1006 (offset -1 lines).
Hunk #4 succeeded at 1260 (offset -1 lines).
Hunk #5 succeeded at 1282 (offset -2 lines).
Hunk #6 succeeded at 1300 (offset -1 lines).
Hunk #7 succeeded at 1321 (offset -2 lines).
Hunk #8 succeeded at 1343 (offset -1 lines).
Hunk #9 FAILED at 1665.
Hunk #10 succeeded at 1724 (offset -3 lines).
Hunk #11 succeeded at 1765 (offset -2 lines).
Hunk #12 succeeded at 1784 (offset -3 lines).
1 out of 12 hunks FAILED -- saving rejects to file
drivers/mtd/nand/nand_base.c.rej
patching file drivers/mtd/mtdchar.c
patching file drivers/mtd/mtdconcat.c
patching file drivers/mtd/nand/nand_bbt.c
patching file drivers/mtd/nftlcore.c
patching file drivers/mtd/ssfdc.c
patching file fs/jffs2/wbuf.c
patching file drivers/mtd/mtdpart.c
patching file include/linux/mtd/mtd.h

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)