Re: [PATCH] powerpc: force 4k update_flash block and list sizes

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]

On Tue, 2006-11-07 at 22:30 -0600, John Rose wrote:
> > kmem_cache_destroy doesn't return anything.
> 
> Good call!  How's this:
> 
> The enablement of 64k pages on POWER platforms exposed a quirk in the RTAS
> mechanism for updating firmware.  RTAS assumes 4k for flash block and list
> sizes, and use of any other sizes results in a failure.
> 
> This patch changes the rtas_flash module to force the use of 4k memory block
> and list sizes when preparing and sending a firmware image to RTAS.  It also
> changes rtas_flash to use a slab cache to ensure 4k alignment of flash block
> data.  Such alignment is a documented requirement.

Just being picky .. but why did you decide to use the slab cache? Does
it make the code neater? I would have thought you could guarantee 4k
alignment some other way, and it seems slightly odd to use the slab
cache for something you only do once ..

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]