From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ development <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] Proposed DTD
Date: Mon, 13 Nov 2006 07:21:58 +0100 [thread overview]
Message-ID: <1163398918.26272.11.camel@localhost> (raw)
In-Reply-To: <200611131114.43541.denis.kenzior@trolltech.com>
Hi Denis,
> > this patch replaces string_t by sdp_buf_t and fix system bus
> > disconnection problem. Check if this patch make sense or if it is
> > better keep string_t.
>
> I agree we should replace string_t by sdp_buf_t since this avoids an extra
> strlen. However, I think that the buffer should be grown by factors. Your
> proposed solution would call realloc many times, as the append function is
> called quite frequently with small strings, but this is no biggie.
>
> Would the attached patch be better?
looks good to me.
Claudio, please review it and then commit this to the CVS.
Regards
Marcel
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
next prev parent reply other threads:[~2006-11-13 6:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 0:25 [Bluez-devel] Proposed DTD Denis KENZIOR
2006-10-23 3:13 ` Marcel Holtmann
2006-10-23 3:59 ` Denis KENZIOR
2006-10-23 4:11 ` Marcel Holtmann
2006-10-23 4:31 ` Denis KENZIOR
2006-10-23 7:27 ` Marcel Holtmann
2006-10-24 5:47 ` Denis KENZIOR
2006-10-24 8:13 ` Marcel Holtmann
2006-10-24 6:47 ` Denis KENZIOR
2006-10-24 9:16 ` Marcel Holtmann
2006-10-24 8:09 ` Denis KENZIOR
2006-10-24 10:17 ` Marcel Holtmann
2006-10-30 13:27 ` Marcel Holtmann
2006-11-09 1:49 ` Denis KENZIOR
2006-11-10 18:09 ` Claudio Takahasi
2006-11-10 21:38 ` Claudio Takahasi
2006-11-13 1:14 ` Denis KENZIOR
2006-11-13 6:21 ` Marcel Holtmann [this message]
2006-11-13 6:37 ` Marcel Holtmann
2006-11-13 7:03 ` Denis KENZIOR
2006-11-13 7:17 ` Marcel Holtmann
2006-10-24 7:08 ` Denis KENZIOR
2006-10-24 9:13 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163398918.26272.11.camel@localhost \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.