From: Ingo Molnar <mingo@redhat.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value
Date: Mon, 13 Nov 2006 09:08:31 +0100 [thread overview]
Message-ID: <1163405311.7473.48.camel@earth> (raw)
In-Reply-To: <20061112174826.GC3382@stusta.de>
On Sun, 2006-11-12 at 18:48 +0100, Adrian Bunk wrote:
> The Coverity checker noted that bad things might happen if
> find_isa_irq_apic() returned -1.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
hm, it seems the checker did not notice the following:
find_isa_irq_apic() can return -1 /only/ if find_isa_irq_pin() returns
-1 too. So this is not a bug - it's rather a bit unclean code (and
adding a check for -1 apic does not make the code cleaner).
Ingo
next prev parent reply other threads:[~2006-11-13 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-12 17:48 [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value Adrian Bunk
2006-11-13 8:08 ` Ingo Molnar [this message]
2006-11-14 0:42 ` Andrew Morton
2006-11-14 6:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163405311.7473.48.camel@earth \
--to=mingo@redhat.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.