From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [BUG] commit #1833 breaks rt_queue_create
Date: Wed, 15 Nov 2006 23:17:57 +0100 [thread overview]
Message-ID: <1163629078.4974.30.camel@domain.hid> (raw)
In-Reply-To: <455B82F3.702@domain.hid>
On Wed, 2006-11-15 at 22:13 +0100, Jan Kiszka wrote:
> As xnheap_size() changed, a sanity check in xnheap_mmap fails now, at
> least for SVN head, maybe also 2.2.x.
>
> I would suggest the following patch to fix this, though I'm not 100%
> sure its correct in all cases
It's correct. xnheap_size() is sent back to user-space when creating the
queue, which forwards this in turn to the mmap handler.
> (do we ever come across a heap of multiple
> extents in xnheap_mmap?).
Yes we do, particularly for ppc which needs this for the system heap.
However, we should not allow mmaping multi-extent heaps. Merged fixes
and added sanity check to prevent the latter issue. Thanks.
>
> Jan
>
>
> PS: I'll spent a beer (or two...) for the one who starts writing a
> testsuite for the native skin - in user-space, please, to catch also
> issues like this one.
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
--
Philippe.
prev parent reply other threads:[~2006-11-15 22:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 21:13 [Xenomai-core] [BUG] commit #1833 breaks rt_queue_create Jan Kiszka
2006-11-15 21:23 ` Jan Kiszka
2006-11-15 22:17 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163629078.4974.30.camel@domain.hid \
--to=rpm@xenomai.org \
--cc=jan.kiszka@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.