From: Christophe Varoqui <christophe.varoqui@free.fr>
To: David Wysochanski <dave.wysochanski@redhat.com>
Cc: dm-devel@redhat.com, Edward Goggin <egoggin@emc.com>
Subject: RE: patch to discovery.c to still get pathpriorityforpaths with path state of PATH_DOWN
Date: Wed, 15 Nov 2006 23:57:24 +0100 [thread overview]
Message-ID: <1163631444.10466.146.camel@localhost.localdomain> (raw)
In-Reply-To: <1163630615.14577.4.camel@dhcp59-220.rdu.redhat.com>
> > Please have a careful look at the multipath/main.c:update_paths change,
> > because the (!pp->priority) that was there awfully looks like a bug (as
> > 0 is not a defined prio value).
> >
>
> 0 is the value you'll get though after alloc_path and before anyone
> calls pathinfo right?
>
You're right. I forgot the memset(0...) through MALLOC().
> Your patch should be equivalent though and is clearer.
>
Then merged.
Now that this issue is cleared, I'll push the head to korg.
Regards,
cvaroqui
next prev parent reply other threads:[~2006-11-15 22:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 23:01 patch to discovery.c to still get path priority for paths with path state of PATH_DOWN Edward Goggin
2006-11-13 20:04 ` Dave Wysochanski
2006-11-13 20:47 ` patch to discovery.c to still get path priority forpaths " Edward Goggin
2006-11-14 14:26 ` Dave Wysochanski
2006-11-14 20:09 ` patch to discovery.c to still get path priorityforpaths " Edward Goggin
2006-11-15 6:48 ` Dave Wysochanski
2006-11-15 19:48 ` patch to discovery.c to still get pathpriorityforpaths " Edward Goggin
2006-11-15 20:28 ` Dave Wysochanski
2006-11-15 22:33 ` Christophe Varoqui
2006-11-15 22:43 ` David Wysochanski
2006-11-15 22:57 ` Christophe Varoqui [this message]
2006-11-15 22:48 ` patch to discovery.c to still getpathpriorityforpaths " Edward Goggin
2006-11-15 22:58 ` Christophe Varoqui
2006-11-15 23:09 ` Dave Wysochanski
2006-11-17 13:49 ` patch to discovery.c to stillgetpathpriorityforpaths " Edward Goggin
2006-11-17 21:06 ` Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163631444.10466.146.camel@localhost.localdomain \
--to=christophe.varoqui@free.fr \
--cc=dave.wysochanski@redhat.com \
--cc=dm-devel@redhat.com \
--cc=egoggin@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.