From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: consolidated xencomm Date: Thu, 16 Nov 2006 15:52:57 -0600 Message-ID: <1163713977.26011.74.camel@basalt> References: <1163692542.26011.14.camel@basalt> <1163700499.5529.9.camel@lappy> <20061116204420.GC2568@saphi> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061116204420.GC2568@saphi> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tristan Gingold Cc: xen-ppc-devel , xen-devel@lists.xensource.com, Alex Williamson , xen-ia64-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thu, 2006-11-16 at 21:44 +0100, Tristan Gingold wrote: > On Thu, Nov 16, 2006 at 11:08:19AM -0700, Alex Williamson wrote: > > On Thu, 2006-11-16 at 09:55 -0600, Hollis Blanchard wrote: > > > > > > I think I'm missing something. Why did IA64 fork xencomm? > > > > > > I distinctly remember having conversations about sharing the code, which > > > is obviously the right thing to do. > > > > Because Tristan believed the resulting amount of shared code would > > actually be very small (1 file) and we wanted to get his work into the > > tree before he left Bull. We can still work to share as much as > > possible even with the code split. Thanks, > Indeed. Only asm/guest_access.h can be easily shared. Feel free to do it. > > For the other files, sharing can't be easily done. We have slightly changed > the interface (we now have 3 ways: inline, mini and area). Furthermore > the translators are not very stable: bugs have been fixed recently. Sharing can't easily be done *because* you've changed the interface, not the other way around. The patch I cited earlier today is a bug fix that applies to PowerPC as well, but the code is not shared, and the patch did not fix both architectures. -- Hollis Blanchard IBM Linux Technology Center