From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Jakub Narebski <jnareb@gmail.com>
Subject: [PATCH 1/5] gitweb: Protect against possible warning in git_commitdiff
Date: Sat, 18 Nov 2006 23:35:38 +0100 [thread overview]
Message-ID: <11638893431855-git-send-email-jnareb@gmail.com> (raw)
In-Reply-To: <1163889342877-git-send-email-jnareb@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
I'm not sure _when_ this eror (warning) occur, as it happened to me
once, but I couldn't repeat it; but I didn't try too hard.
I think it is better coding practice, and more readable.
gitweb/gitweb.perl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7587595..b2482fe 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3731,7 +3731,8 @@ sub git_commitdiff {
$hash_parent, $hash, "--"
or die_error(undef, "Open git-diff-tree failed");
- while (chomp(my $line = <$fd>)) {
+ while (my $line = <$fd>) {
+ chomp $line;
# empty line ends raw part of diff-tree output
last unless $line;
push @difftree, $line;
--
1.4.3.4
next prev parent reply other threads:[~2006-11-18 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-18 22:35 [PATCH 0/5] gitweb: New patchset view corrections and improvements, and few other things Jakub Narebski
2006-11-18 22:35 ` Jakub Narebski [this message]
2006-11-18 22:38 ` [PATCH 1/5] gitweb: Protect against possible warning in git_commitdiff Jakub Narebski
2006-11-18 22:35 ` [PATCH 2/5] gitweb: Buffer diff header to deal with split patches + git_patchset_body refactoring Jakub Narebski
2006-11-18 22:35 ` [PATCH 3/5] gitweb: New improved formatting of chunk header in diff Jakub Narebski
2006-11-18 22:35 ` [PATCH 4/5] gitweb: Default to $hash_base or HEAD for $hash in "commit" and "commitdiff" Jakub Narebski
2006-11-18 22:35 ` [PATCH 5/5] gitweb: Add an option to href() to return full URL Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11638893431855-git-send-email-jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.