Re: [Bluez-devel] PATCH for dund : correct --dialup behavior (Tomtom GPS)

[Marcel Holtmann <marcel@holtmann.org>]

Hi Valentin,

> It's my really first contribution to the GPL world, and I'm not familiar 
> with the developpment tools. :-)

don't worry. We tell you, but I think the difference between a context
diff and unified diff is quite clear. I simply can't review any diff
that is not in unified format. Actually this should be default, but it
isn't.

> This one might be better... (it works for me with "patch < mypatch" in 
> the correct directory)
> 
> --- sdp.c       2006-05-23 14:48:37.000000000 +0200
> +++ sdp.c       2006-11-19 11:37:10.000000000 +0100
> @@ -171,6 +171,9 @@ int dun_sdp_search(bdaddr_t *src, bdaddr
>         case ACTIVESYNC:
>                 sdp_uuid128_create(&svclass, (void *) async_uuid);
>                 break;
> +       case DIALUP:
> +               sdp_uuid16_create(&svclass, DIALUP_NET_SVCLASS_ID);
> +               break;
>         default:
>                 sdp_uuid16_create(&svclass, LAN_ACCESS_SVCLASS_ID);
>                 break;

Patch has been committed to the CVS. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel