From: Artem Bityutskiy <dedekind@infradead.org>
To: Dragan Marinkovic <marinkovic.dragan@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: jffs2_truncate_fragtree does not handle NULL return from jffs2_lookup_node_frag
Date: Wed, 22 Nov 2006 18:27:04 +0200 [thread overview]
Message-ID: <1164212824.19298.21.camel@sauron> (raw)
In-Reply-To: <d33135570611212335p76f32b82k13c3a8a0671d4e24@mail.gmail.com>
On Tue, 2006-11-21 at 23:35 -0800, Dragan Marinkovic wrote:
> Digging a bit deeper, I found that jffs2_truncate_fragtree is not
> handling the NULL as a return value from jffs2_lookup_node_frag . It looks
> like that NULL return is perfectly legal. The patch to fix this is attached.
> I'm not really sure if this is the right place to fix this problem but
> it should be OK from the correctness prospective (can't use NULL
> pointers).
The NULL is legal, but JFFS2 does handle it. Look at the latest git
version. Please, point which particular C operation in the
jffs2_truncate_fragtree() function causes the oops.
> More to it, I've noticed that if I remove the system power while file
> on JFFS2 partition is being updated (it takes a bit of time to hit the
> right moment), I'll completely lose the file (it just disappears). Any
> ideas?
What does "JFFS2 partition is being updated" mean?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2006-11-22 16:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 7:35 jffs2_truncate_fragtree does not handle NULL return from jffs2_lookup_node_frag Dragan Marinkovic
2006-11-22 16:27 ` Artem Bityutskiy [this message]
2006-11-22 16:49 ` Dragan Marinkovic
2006-11-22 16:55 ` Artem Bityutskiy
2006-11-22 18:50 ` Dragan Marinkovic
2006-11-22 17:19 ` Artem Bityutskiy
2006-11-22 17:22 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164212824.19298.21.camel@sauron \
--to=dedekind@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marinkovic.dragan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.