From: Zhang Rui <rui.zhang@intel.com>
To: Len Brown <lenb@kernel.org>
Cc: "linux-acpi@vger" <linux-acpi@vger.kernel.org>
Subject: Re: [11/12] acpi: acpi pci bridge driver
Date: Fri, 24 Nov 2006 13:32:45 +0800 [thread overview]
Message-ID: <1164346365.5768.24.camel@localhost.localdomain> (raw)
In-Reply-To: <200611232239.34046.len.brown@intel.com>
On Thu, 2006-11-23 at 22:39 -0500, Len Brown wrote:
> > Index: linux-2.6.18-rc7/drivers/acpi/scan.c
> > ===================================================================
> > --- linux-2.6.18-rc7.orig/drivers/acpi/scan.c 2006-09-19 19:55:25.000000000 +0800
> > +++ linux-2.6.18-rc7/drivers/acpi/scan.c 2006-09-19 19:55:52.000000000 +0800
> > @@ -865,12 +865,13 @@ static int acpi_bus_remove(struct acpi_d
> >
> > if (!rmdevice)
> > return 0;
> > -
> > + /* FIXME: device_release_driver will automically call unbind, is this ok */
> > +#if 0
> > if (dev->flags.bus_address) {
> > if ((dev->parent) && (dev->parent->ops.unbind))
> > dev->parent->ops.unbind(dev);
> > }
> > -
> > +#endif
>
> eh?
Code here should never be executed.
all the acpi-pci bridges(except root bridge) are managed by this acpi-
pci bridge driver . The bind and unbind methods are called automatically
in the .add/.remove method now.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2006-11-24 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 9:51 [11/12] acpi: acpi pci bridge driver Zhang Rui
2006-11-24 3:39 ` Len Brown
2006-11-24 5:32 ` Zhang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164346365.5768.24.camel@localhost.localdomain \
--to=rui.zhang@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.