From: Pavel Roskin <proski@gnu.org>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Don't require config file for "stg mail"
Date: Wed, 29 Nov 2006 18:27:21 -0500 [thread overview]
Message-ID: <1164842841.23643.28.camel@dv> (raw)
In-Reply-To: <b0943d9e0611290829h291942d7x13247511d16afeee@mail.gmail.com>
Hello, Catalin!
On Wed, 2006-11-29 at 16:29 +0000, Catalin Marinas wrote:
> On 29/11/06, Pavel Roskin <proski@gnu.org> wrote:
> > When calculating the string to be used in the From: field, don't require
> > it to come from the configuration file. Instead, reuse already known
> > authname and authemail values as the default. They can be taken from
> > the GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL environment variables.
>
> Your patch uses the author of the patch which can be different from
> the person sending the e-mail. It could indeed use the author from GIT
> variables or configuration (not the patch author) and I already have a
> patch from Karl Hasselström for this (which I haven't found the time
> to check properly).
The funny thing it, GIT_AUTHOR_NAME and GIT_AUTHOR_EMAIL are only used
in the code to determine the author of the patch.
Apparently, things are more twisted than I expected, so they need some
untangling first.
> Once I merge Karl's patch, I'll modify StGIT to use the GIT defaults
> if there is no sender configured.
Sounds good.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2006-11-29 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 3:59 [PATCH 1/2] Set HOME to the test directory to avoid reading ~/.stgitrc Pavel Roskin
2006-11-29 3:59 ` [PATCH 2/2] Don't require config file for "stg mail" Pavel Roskin
2006-11-29 16:29 ` Catalin Marinas
2006-11-29 23:27 ` Pavel Roskin [this message]
2006-11-30 8:32 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164842841.23643.28.camel@dv \
--to=proski@gnu.org \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.