From: Ingo Molnar <mingo@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>,
ak@suse.de
Subject: Re: [PATCH -mm] x86_64 UP needs smp_call_function_single
Date: Thu, 30 Nov 2006 10:22:20 +0100 [thread overview]
Message-ID: <1164878540.11036.29.camel@earth> (raw)
In-Reply-To: <20061129235407.7295c31d.akpm@osdl.org>
On Wed, 2006-11-29 at 23:54 -0800, Andrew Morton wrote:
> which is somewhat unpleasant. I added a WARN_ON(irqs_disabled()) to
> the
> out-of-line SMP version.
ok.
>
> btw, does anyone know why the SMP versions of this function use
> spin_lock_bh(&call_lock)?
that makes no sense (neither the get_cpu()/put_cpu() gymnastics) if this
is called with irqs disabled all the time.
Ingo
>
next prev parent reply other threads:[~2006-11-30 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 1:01 [PATCH -mm] x86_64 UP needs smp_call_function_single Randy Dunlap
2006-11-30 1:45 ` Andrew Morton
2006-11-30 7:00 ` Ingo Molnar
2006-11-30 7:54 ` Andrew Morton
2006-11-30 9:22 ` Ingo Molnar [this message]
2006-11-30 9:35 ` Andrew Morton
2006-11-30 22:11 ` Randy Dunlap
2006-11-30 22:27 ` Andrew Morton
2006-11-30 22:31 ` Randy Dunlap
2006-11-30 23:14 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164878540.11036.29.camel@earth \
--to=mingo@redhat.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.