From: Michael Neuling <mikey@neuling.org>
To: kexec@lists.infradead.org, horms@verge.net.au
Subject: [PATCH] fix valid_memory_range region merging
Date: Thu, 26 Apr 2007 16:50:34 +1000 [thread overview]
Message-ID: <1165.1177570234@neuling.org> (raw)
Check the next region we are including is type RANGE_RAM as well.
Signed-off-by: Michael Neuling <mikey@neuling.org>
---
I've not actually seen this cause a problem, but it looks wrong. We
should probably merge regions properly and solve this problem for real.
kexec/kexec.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: kexec-tools-testing/kexec/kexec.c
===================================================================
--- kexec-tools-testing.orig/kexec/kexec.c
+++ kexec-tools-testing/kexec/kexec.c
@@ -96,7 +96,8 @@ int valid_memory_range(struct kexec_info
mstart = info->memory_range[i].start;
mend = info->memory_range[i].end;
if (i < info->memory_ranges - 1
- && mend == info->memory_range[i+1].start)
+ && mend == info->memory_range[i+1].start
+ && info->memory_range[i+1].type == RANGE_RAM)
mend = info->memory_range[i+1].end;
/* Check to see if we are fully contained */
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2007-04-26 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 6:50 Michael Neuling [this message]
2007-04-26 7:17 ` [PATCH] fix valid_memory_range region merging Simon Horman
2008-02-26 2:29 ` Simon Horman
2008-02-26 9:29 ` Michael Neuling
2008-02-26 9:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165.1177570234@neuling.org \
--to=mikey@neuling.org \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.