From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: adeos-main@gna.org
Subject: Re: [Adeos-main] [PATCHES] cleanup minor quirks for 1.6-01
Date: Sun, 03 Dec 2006 15:50:05 +0100 [thread overview]
Message-ID: <1165157406.4952.366.camel@domain.hid> (raw)
In-Reply-To: <1165157023.4952.361.camel@domain.hid>
On Sun, 2006-12-03 at 15:43 +0100, Philippe Gerum wrote:
> On Sun, 2006-12-03 at 15:13 +0100, Jan Kiszka wrote:
> > Hi,
> >
> > I came across a few things in latest 2.6.19-i386-1.6-01 patch:
> >
> > The usage of __ipipe_pipelock in __ipipe_common_info_proc is broken (raw lock used as
> > Linux lock here), and I do not see any volatile data it could protect anyway. So let's
> > remove it.
>
> The interrupt status word, and whether any virtual interrupt is
> allocated or not, are the volatile data protected by this lock on a SMP
> system. Since this is a common spinlock with no interrupt control
> required which is only used over the Linux domain (/proc handler), you
> don't need to go for the _hw() form of it.
>
M, actually, the problem is elsewhere: we should disable hw IRQs here,
so that other domains could not compete with us on this lock.
--
Philippe.
next prev parent reply other threads:[~2006-12-03 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 14:13 [Adeos-main] [PATCHES] cleanup minor quirks for 1.6-01 Jan Kiszka
2006-12-03 14:43 ` Philippe Gerum
2006-12-03 14:50 ` Philippe Gerum [this message]
2006-12-03 15:05 ` Jan Kiszka
2006-12-03 15:47 ` Philippe Gerum
2006-12-03 18:01 ` Jan Kiszka
2006-12-03 20:22 ` Philippe Gerum
2006-12-06 23:38 ` Jan Kiszka
2006-12-14 20:53 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165157406.4952.366.camel@domain.hid \
--to=rpm@xenomai.org \
--cc=adeos-main@gna.org \
--cc=jan.kiszka@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.