From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, akpm@osdl.org, linux390@de.ibm.com,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] WorkStruct: Fix S390 driver workstruct usage
Date: Sat, 09 Dec 2006 20:51:09 +0100 [thread overview]
Message-ID: <1165693869.17186.5.camel@localhost> (raw)
In-Reply-To: <20061208173342.GT4587@ftp.linux.org.uk>
On Fri, 2006-12-08 at 17:33 +0000, Al Viro wrote:
> I don't think it's a real fix.
>
> a) what protects tty from disappearing?
Nothing..
> b) why the hell do we need that schedule_work() at all? handle_sysrq() is
> supposed to be safe to use from irq handler; when needed it does arrange for
> delayed execution itself.
Fritz probably did that because earlier versions of handle_sysrq() could
not be called in interrupt context. ctrlchar.c is rather old, the first
checkin I can see is from 2001/01/18.
> So how about we simply call handle_sysrq() there and be done with that?
> Martin?
If it works that is fine with me. Another simplification. I take a look
at it next week.
--
blue skies,
Martin.
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
"Reality continues to ruin my life." - Calvin.
prev parent reply other threads:[~2006-12-09 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 14:59 [PATCH] WorkStruct: Fix S390 driver workstruct usage David Howells
2006-12-08 15:36 ` Martin Schwidefsky
2006-12-08 17:33 ` Al Viro
2006-12-08 18:48 ` Al Viro
2006-12-09 19:51 ` Martin Schwidefsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165693869.17186.5.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.