From: Marcel Holtmann <marcel@holtmann.org>
To: Florian Festi <ffesti@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input/usb: Supporting more keys from the HUT Consumer Page
Date: Mon, 11 Dec 2006 20:30:41 +0100 [thread overview]
Message-ID: <1165865441.20733.12.camel@localhost> (raw)
In-Reply-To: <457D8E59.2000200@redhat.com>
Hi Florian,
> On USB keyboards lots of hot/internet keys are not working. This patch
> adds support for a number of keys from the USB HID Usage Table
> (http://www.usb.org/developers/devclass_docs/Hut1_12.pdf).
>
> It also adds several new key codes. Most of them are used on real world
> keyboards I know. I added some others (KEY_+ EDITOR, GRAPHICSEDITOR,
> DATABASE, NEWS, VOICEMAIL, VIDEOPHONE) to avoid "holes".
>
> I would be interested in comments to the "zoom" key. For me it looks
> like KEY_ZOOM is on a remote control for a DVD player or something
> similar. So it toggles between a few zoom levels. The Zoom 100% key
> found on keyboards (some Logitech internet keyboards for example) resets
> the Zoom to 100%. May be we need another keycode for them. Additionally
> does the USB HUT define the Zoom entry as "linear control" but the
> logitech uses it as Zoom 100% key.
we just split the HID parser from the actual USB transport driver and it
seems your patch is against an old tree. Please update your patch.
Regards
Marcel
next prev parent reply other threads:[~2006-12-11 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 16:59 [PATCH] input/usb: Supporting more keys from the HUT Consumer Page Florian Festi
2006-12-11 19:30 ` Marcel Holtmann [this message]
2006-12-12 9:49 ` [PATCH] input/hid: " Florian Festi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165865441.20733.12.camel@localhost \
--to=marcel@holtmann.org \
--cc=ffesti@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.