All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@XenSource.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Gerd Hoffmann <kraxel@suse.de>, xen-devel@lists.xensource.com
Subject: Re: Re: [patch] Add kexec_ops & function pointers
Date: Tue, 12 Dec 2006 11:27:02 +0000	[thread overview]
Message-ID: <1165922822.23643.34.camel@localhost.localdomain> (raw)
In-Reply-To: <aec7e5c30612112312s268d173h5cd3bece08034614@mail.gmail.com>

On Tue, 2006-12-12 at 16:12 +0900, Magnus Damm wrote:
> Basically, machine_kexec() should be converted to kexec_ops.kexec() in
> two places. The second place is unfortunately located in
> linux/kernel/sys.c which does not exist in sparse yet. So that needs
> to be resolved somehow.

Hiding the indirections through the function table in the header via
defines or inline functions would make things a lot cleaner in my
opinion and as a bonus avoid this addition to the sparse tree.

That is the approach taken by the paravirt_ops stuff so it would also
make it easier to integrate with that in the future.

Ian.

  parent reply	other threads:[~2006-12-12 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08 16:17 [patch] Add kexec_ops & function pointers Gerd Hoffmann
2006-12-12  7:12 ` Magnus Damm
2006-12-12  8:44   ` Gerd Hoffmann
2006-12-12 11:27   ` Ian Campbell [this message]
2006-12-12 12:48     ` Gerd Hoffmann
2006-12-12 15:45       ` Ian Campbell
2006-12-12 16:13         ` Gerd Hoffmann
2006-12-12 16:18           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1165922822.23643.34.camel@localhost.localdomain \
    --to=ian.campbell@xensource.com \
    --cc=kraxel@suse.de \
    --cc=magnus.damm@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.