From: Ralph Campbell <ralph.campbell@qlogic.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sg_dma_address and sg_dma_len
Date: Wed, 13 Dec 2006 12:45:00 -0800 [thread overview]
Message-ID: <1166042700.14800.392.camel@brick.pathscale.com> (raw)
In-Reply-To: <200612131737.kBDHb47D013437@agluck-lia64.sc.intel.com>
On Wed, 2006-12-13 at 09:37 -0800, Luck, Tony wrote:
> Ralph,
>
> I'm seeing dozens of build warnings and errors on ia64 from
> infiniband. According to git you touched it last, so even
> if you aren't to blame, you are by definition an expert :-)
>
> E.g.
>
> In file included from include/rdma/ib_addr.h:37,
> from drivers/infiniband/core/addr.c:39:
> include/rdma/ib_verbs.h: In function `ib_sg_dma_address':
> include/rdma/ib_verbs.h:1572: warning: implicit declaration of function `sg_dma_address'
> include/rdma/ib_verbs.h: In function `ib_sg_dma_len':
> include/rdma/ib_verbs.h:1584: warning: implicit declaration of function `sg_dma_len'
>
> Adding a #include <linux/pci.h> would shut them up (as the defines for
> sg_dma_address and sg_dma_len are in asm/pci.h) ... but I've no idea
> whether this is the right fix.
>
> -Tony
For some reason ia64 defines sg_dma_address() in include/asm-ia64/pci.h
instead of include/asm-ia64/scatterlist.h like most other architectures.
Since pci.h includes <asm/scatterlist.h> it seems like the fix would be
to move the two lines:
#define sg_dma_len(sg) ((sg)->dma_length)
#define sg_dma_address(sg) ((sg)->dma_address)
to include/asm-ia64/scatterlist.h
Now that I look, I see asm-sh64/pci.h and asm-frv/dma-mapping.h
would also need to be changed.
next prev parent reply other threads:[~2006-12-13 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 17:37 sg_dma_address and sg_dma_len Luck, Tony
2006-12-13 20:45 ` Ralph Campbell [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-13 22:14 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166042700.14800.392.camel@brick.pathscale.com \
--to=ralph.campbell@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.