From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bob Brose <linuxppcdev@qbjnet.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix irq routing on some PowerMac 32
Date: Thu, 14 Dec 2006 09:32:35 +1100 [thread overview]
Message-ID: <1166049155.11914.215.camel@localhost.localdomain> (raw)
In-Reply-To: <20061213190958.16479.qmail@kunk.qbjnet.com>
What about that patch ? If it doesn't help, please send me a new dmesg
log of 2.6.19 with patches -and- with #defin'ing DEBUG in
arch/powerpc/kernel/pci_32.c and prom_parse.c.
Index: linux-work/arch/powerpc/kernel/prom_parse.c
===================================================================
--- linux-work.orig/arch/powerpc/kernel/prom_parse.c 2006-12-14 09:27:22.000000000 +1100
+++ linux-work/arch/powerpc/kernel/prom_parse.c 2006-12-14 09:29:36.000000000 +1100
@@ -920,9 +920,20 @@
/*
* Old machines just have a list of interrupt numbers
- * and no interrupt-controller nodes.
+ * and no interrupt-controller nodes. We also have dodgy
+ * cases where the APPL,interrupts property is completely
+ * missing behind pci-pci bridges and we have to get it
+ * from the parent (the bridge itself, as apple just wired
+ * everything together on these)
*/
- ints = get_property(device, "AAPL,interrupts", &intlen);
+ while (device) {
+ ints = get_property(device, "AAPL,interrupts", &intlen);
+ if (ints != NULL)
+ break;
+ device = device->parent;
+ if (device && strcmp(device->type, "pci") != 0)
+ break;
+ }
if (ints == NULL)
return -EINVAL;
intlen /= sizeof(u32);
next prev parent reply other threads:[~2006-12-13 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-13 19:09 [PATCH] powerpc: Fix irq routing on some PowerMac 32 Bob Brose
2006-12-13 22:16 ` Benjamin Herrenschmidt
2006-12-13 22:32 ` Benjamin Herrenschmidt [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-14 16:16 Bob Brose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1166049155.11914.215.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppcdev@qbjnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.