From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Jonathan Toppins <jtoppins@redhat.com>
Cc: netdev@vger.kernel.org, liuhangbin@gmail.com
Subject: Re: [PATCH net v5 0/3] bonding: 802.3ad: fix no transmission of LACPDUs
Date: Fri, 19 Aug 2022 13:13:30 -0700 [thread overview]
Message-ID: <11676.1660940010@famine> (raw)
In-Reply-To: <cover.1660919940.git.jtoppins@redhat.com>
Jonathan Toppins <jtoppins@redhat.com> wrote:
>Configuring a bond in a specific order can leave the bond in a state
>where it never transmits LACPDUs.
>
>The first patch adds some kselftest infrastructure and the reproducer
>that demonstrates the problem. The second patch fixes the issue. The
>new third patch makes ad_ticks_per_sec a static const and removes the
>passing of this variable via the stack.
For the series:
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
>v5:
> * fixup kdoc
>v4:
> * rebased to latest net/master
> * removed if check around bond_3ad_initialize function contents
> * created a new patch that makes ad_ticks_per_sec a static const
>v3:
> * rebased to latest net/master
> * addressed comment from Hangbin
>
>Jonathan Toppins (3):
> selftests: include bonding tests into the kselftest infra
> bonding: 802.3ad: fix no transmission of LACPDUs
> bonding: 3ad: make ad_ticks_per_sec a const
>
> MAINTAINERS | 1 +
> drivers/net/bonding/bond_3ad.c | 41 ++++------
> drivers/net/bonding/bond_main.c | 2 +-
> include/net/bond_3ad.h | 2 +-
> tools/testing/selftests/Makefile | 1 +
> .../selftests/drivers/net/bonding/Makefile | 6 ++
> .../net/bonding/bond-break-lacpdu-tx.sh | 81 +++++++++++++++++++
> .../selftests/drivers/net/bonding/config | 1 +
> .../selftests/drivers/net/bonding/settings | 1 +
> 9 files changed, 108 insertions(+), 28 deletions(-)
> create mode 100644 tools/testing/selftests/drivers/net/bonding/Makefile
> create mode 100755 tools/testing/selftests/drivers/net/bonding/bond-break-lacpdu-tx.sh
> create mode 100644 tools/testing/selftests/drivers/net/bonding/config
> create mode 100644 tools/testing/selftests/drivers/net/bonding/settings
>
>--
>2.31.1
>
next prev parent reply other threads:[~2022-08-19 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 15:15 [PATCH net v5 0/3] bonding: 802.3ad: fix no transmission of LACPDUs Jonathan Toppins
2022-08-19 15:15 ` [PATCH net v5 1/3] selftests: include bonding tests into the kselftest infra Jonathan Toppins
2022-08-19 15:15 ` [PATCH net v5 2/3] bonding: 802.3ad: fix no transmission of LACPDUs Jonathan Toppins
2022-08-19 15:15 ` [PATCH net v5 3/3] bonding: 3ad: make ad_ticks_per_sec a const Jonathan Toppins
2022-08-19 20:13 ` Jay Vosburgh [this message]
2022-08-20 4:36 ` [PATCH net v5 0/3] bonding: 802.3ad: fix no transmission of LACPDUs Jay Vosburgh
2022-08-23 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11676.1660940010@famine \
--to=jay.vosburgh@canonical.com \
--cc=jtoppins@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.