From: Hollis Blanchard <hollisb@us.ibm.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
p.hardwick@option.com
Subject: Re: tty->low_latency + irq context
Date: Tue, 02 Jan 2007 13:36:01 -0600 [thread overview]
Message-ID: <1167766562.5616.29.camel@basalt> (raw)
In-Reply-To: <20070102183829.10d861fc@localhost.localdomain>
On Tue, 2007-01-02 at 18:38 +0000, Alan wrote:
> > with tty->low_latency set, but it doesn't AFAICS. One possibility
> for
> > deadlock is if the tty->buf.lock spinlock is taken on behalf of a
> user
> > process...
>
> The case to watch out for is
>
> flip_buffer_push -> ldisc -> driver write of echo/^S/^Q
>
> if you call flip_buffer_push while holding your own lock you may get
> in a mess on the echo path.
Agreed. However, that's not what the comment says:
* tty_flip_buffer_push - terminal
* @tty: tty to push
*
* Queue a push of the terminal flip buffers to the line discipline. This
* function must not be called from IRQ context if tty->low_latency is set.
--
Hollis Blanchard
IBM Linux Technology Center
prev parent reply other threads:[~2007-01-02 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-26 0:09 tty->low_latency + irq context Jiri Slaby
2007-01-02 17:17 ` Hollis Blanchard
2007-01-02 18:12 ` Paul Fulghum
2007-01-02 18:29 ` Paul Fulghum
2007-01-02 18:38 ` Alan
2007-01-02 19:36 ` Hollis Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1167766562.5616.29.camel@basalt \
--to=hollisb@us.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.hardwick@option.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.