Re: [PATCH] sungem: PHY updates & pause fixes

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

> Thanks for finding these bugs, although that's really strange pause
> behavior you are seeing on your switches.
> 
> By default, we advertise PAUSE but not ASYM PAUSE in the tg3 driver,
> and I get flow control on every switch I have here.

Yeah, that's strange. I still have the debug values at hand:

 - I advertise 0x5e1
 - I read in LPA 0xc9e1 from the switch
(and my bcm PHY tells me Rx and Tx pause disabled in a separate
register)

Now, I cross-over with a TG3 and I get:

 - I advertise 0x5e1 (hopefully same value)
 - I read in LPA 0xc5e1 from the TG3
(and that other register tells me Rx and Tx pause can be enabled).

> You should try to use flow control, even slower than 1000Mbit links.

Sorry, not sure I parse ;-) You mean allowing pause on 10 and 100 as
well ? I sure can, it's easy to fix.

> That's the only problem I can see, would you mind fixing that and
> I'll put your change into my net-2.6 tree and perhaps play around
> with PAUSE on my switches here?

Sure will do.

Ben.