From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@XenSource.com>
Subject: Re: [PATCH] Fix parse_size_and_unit() breakage in
	xen-3.0.4-testing (kdump broken)
Date: Wed, 10 Jan 2007 09:24:22 +0000
Message-ID: <1168421062.24570.20.camel@localhost.localdomain>
References: <20070110084215.13837.79290.sendpatchset@localhost>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20070110084215.13837.79290.sendpatchset@localhost>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Magnus Damm <magnus@valinux.co.jp>
Cc: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com, Hiromichi Itou <ito@begi.net>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2007-01-10 at 17:42 +0900, Magnus Damm wrote:
> Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken)
> 
> Kdump has been broken since xen-3.0.4-testing.hg-13109.
> Many thanks to Hiromichi Itou for tracking this down.
> 
> Signed-Off-By: Magnus Damm <magnus@valinux.co.jp>

I applied a similar fix to xen-unstable.hg in 13282:9865145e53eb. I'll
get it pulled into xen-3.0.4-testing.hg.

> --- 0001/xen/common/lib.c
> +++ work/xen/common/lib.c	2007-01-10 11:18:38.000000000 +0900
> @@ -442,7 +442,7 @@ s64 __moddi3(s64 a, s64 b)
>  unsigned long long parse_size_and_unit(const char *s, const char **ps)
>  {
>  	unsigned long long ret;
> -	const char *s1;
> +	const char *s1 = NULL;
>  
>  	ret = simple_strtoull(s, &s1, 0);

Are you sure this bit is necessary? simple_strtoull always initialises
&s1.

Ian.