From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Livio Soares <livio@eecg.toronto.edu>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix performance monitor exception in 2.6.20-series
Date: Sun, 14 Jan 2007 11:29:04 +1100 [thread overview]
Message-ID: <1168734544.5011.78.camel@localhost.localdomain> (raw)
In-Reply-To: <20070113154029.GA32292@eecg.toronto.edu>
> IMHO, option #1 is very nice, as long as the PMU interrupt handler behaves
> itself. One reason option #1 is desirable is, with PC-sampling, we are now able
> to sample regions _inside_ interrupt-disabled sections (assuming an actual
> external interrupt hasn't really occured yet). Before, with hardware disabling
> of interrupts, the PMU exceptions were necessarily delivered outside of
> interrupt disabled sections.
>
> Anyways, does anyone see a problem with the following patch?
Well, are you absolutely sure that nothing will break as a result of
having a PMU interrupt happening right when it's not expected to ?
You are basically turning the PMU interrupt into an NMI... I'm not sure
how safe that is.
Ben.
next prev parent reply other threads:[~2007-01-14 0:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-13 15:40 [PATCH] Fix performance monitor exception in 2.6.20-series Livio Soares
2007-01-14 0:29 ` Benjamin Herrenschmidt [this message]
2007-01-14 0:39 ` Segher Boessenkool
2007-01-14 17:56 ` Livio Soares
2007-01-15 2:40 ` David Woodhouse
2007-01-15 2:53 ` Paul Mackerras
2007-01-15 3:14 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1168734544.5011.78.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=livio@eecg.toronto.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.