Re: [Patch 1/2] libnfnetlink, iface conversion to string

[Eric Leblond <eric@inl.fr>]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

Le vendredi 19 janvier 2007 à 18:38 +0100, Pablo Neira Ayuso a écrit :
> Patrick McHardy wrote:
> > Eric Leblond wrote:
> >>  /* rtnl_receive - receive netlink packets from rtnetlink socket */
> >> -int rtnl_receive()
> >> +int rtnl_receive(int rtnl_fd)
> > 
> > header file needs to be fixed as well. Is the global rtnl_fd still
> > needed?
> 
> Indeed. Eric, all this global stuff below must dissapear at all, from
> rtnl.c:

I totally agree. Patch was prefixed with RFC because I wanted to see if
API was correct. As there is no problem from this point, I will do the
needed cleaning.

All my apologies to Patrick, a bad vimrc and some mistakes make from
previous patch something awful.

> static struct ifindex_map *ifindex_map[16];

To answer to Patrick, I really don't like to have variable and type with
the same name, it's quiet confusing. That's why I change it to "struct
ifindex_map_t".

BR,
-- 
Eric Leblond <eric@inl.fr>
INL

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 189 bytes --]