All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
	linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 9/14] ps3: add interrupt alloc for outlets
Date: Thu, 25 Jan 2007 14:55:34 +1100	[thread overview]
Message-ID: <1169697334.24996.54.camel@localhost.localdomain> (raw)
In-Reply-To: <45B8188E.7020602@am.sony.com>


> +int ps3_alloc_irq(enum ps3_cpu_binding cpu, unsigned long outlet,
> +	unsigned int *virq)
> +{
> +	return ps3_connect_irq(cpu, outlet, virq);
> +}
> +
> +int ps3_free_irq(unsigned int virq)
> +{
> +	ps3_disconnect_irq(virq);
> +	return 0;
> +}
> +
>  #define PS3_INVALID_OUTLET ((irq_hw_number_t)-1)
>  #define PS3_PLUG_MAX 63

I'm not too fan of this... those 2 functions do strictly -nothing- other
than export the ones they call (not even changing arguments).

So why not export ps3_connect_irq / ps3_disconnect_irq directly ?

Ben.

  reply	other threads:[~2007-01-25  3:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25  2:40 [PATCH 9/14] ps3: add interrupt alloc for outlets Geoff Levand
2007-01-25  3:55 ` Benjamin Herrenschmidt [this message]
2007-01-25 13:41   ` Geert Uytterhoeven
2007-01-25 23:56     ` Geoff Levand
2007-01-26  2:48     ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1169697334.24996.54.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=geoffrey.levand@am.sony.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.