From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HAQ1c-0008AO-Na for mharc-grub-devel@gnu.org; Fri, 26 Jan 2007 07:17:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HAQ1a-0008A2-Q7 for grub-devel@gnu.org; Fri, 26 Jan 2007 07:17:46 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HAQ1Y-00089P-N5 for grub-devel@gnu.org; Fri, 26 Jan 2007 07:17:46 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HAQ1Y-00089K-Gs for grub-devel@gnu.org; Fri, 26 Jan 2007 07:17:44 -0500 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.52) id 1HAQ1Y-00082P-4h for grub-devel@gnu.org; Fri, 26 Jan 2007 07:17:44 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l0QCHbtX027578 for ; Fri, 26 Jan 2007 07:17:37 -0500 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l0QCHb15006830 for ; Fri, 26 Jan 2007 07:17:37 -0500 Received: from [10.34.32.50] (pluto.brq.redhat.com [10.34.32.50]) by pobox.stuttgart.redhat.com (8.12.8/8.12.8) with ESMTP id l0QCHZaK017690 for ; Fri, 26 Jan 2007 13:17:35 +0100 From: Lubomir Kundrak To: The development of GRUB 2 In-Reply-To: <200701261258.20645.okuji@enbug.org> References: <1169724331.3386.51.camel@pluto> <200701261258.20645.okuji@enbug.org> Content-Type: text/plain Organization: Red Hat Inc. Date: Fri, 26 Jan 2007 13:17:35 +0100 Message-Id: <1169813855.3386.78.camel@pluto> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 (2.8.2.1-3.fc6) Content-Transfer-Encoding: 7bit X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] Making use of argp in GRUB utilities X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2007 12:17:46 -0000 On Pi, 2007-01-26 at 12:58 +0100, Yoshinori K. Okuji wrote: > On Thursday 25 January 2007 12:25, Lubomir Kundrak wrote: > > I've noticed, that GRUB 2 uses argp in grub-emu [1], whereas other > > utilities use getopt_long [2]. Wouldn't it be nice to make this > > consistent? > > Maybe. > > > I find the "GNU way," argp, approach more elegant, as demonstrated by a > > patch to util/i386/pc/grub-mkimage.c. Seeing a patch with more minuses > > than pluses is a good sign, indeed. > > > > The main argument against agrp framework could be, that non-GNU C > > libraries do not contain with it. There's a standalone libargp package > > [3] that is available for package systems of all major operating > > systems, including NetBSD and FreeBSD, so the only disadvantage is > > addding a dependency there. > > I preferred that libargp would be included in our source tree so that it would > be used when argp is not found in a system, but I guess Marco hasn't done it > yet. This depends on which is more convenient for users, using an external > shared library, or using our own. In GRUB Legacy, I included getopt for *BSD, > and I got positive answers. So I feel that it would be better to include. Sound reasonable. Would it be of any use if I converted other utils to make use of argp in my spare time? > > Okuji -- Lubomir Kundrak (Red Hat Security Response Team)