Re: [PATCH 1/2] null_blk: fix opening closed zones at the active zone limit

[Damien Le Moal <dlemoal@kernel.org>]

On 2026/10/21 22:21, Niklas Cassel wrote:
> When the open zone limit is reached, null_check_open() closes an
> implicitly open zone only if the active zone limit is not reached.
> 
> Closing an implicitly open zone does not change the number of active
> zones, so this check is wrong. For an empty zone, the active zone limit
> was already checked by null_check_zone_resources(). For a closed zone,
> the check makes writing to, opening or finishing the zone fail with
> BLK_STS_ZONE_OPEN_RESOURCE at the active zone limit, whereas ZBC-3
> (4.5.3.2.7.2) and NVMe ZNS (2.1.1.4.1) require closing an implicitly
> open zone instead.
> 
> Remove the check, and update the comment above
> null_check_zone_resources() accordingly.
> 
> Fixes: dc4d137ee3b7 ("null_blk: add support for max open/active zone limit for zoned devices")
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research