From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@hp.com>
Subject: Re: [Xen-staging] [xen-unstable] ia64,
	ppc: Remove uses of sprintf().
Date: Tue, 30 Jan 2007 10:03:02 -0700
Message-ID: <1170176582.10792.101.camel@bling>
References: <200701301614.l0UGEJgQ026181@latara.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200701301614.l0UGEJgQ026181@latara.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Christoph Egger <Christoph.Egger@amd.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2007-01-30 at 16:14 +0000, Xen staging patchbot-unstable wrote:
> diff -r 300c47bec138 -r bd69e83b65ea xen/arch/ia64/linux-xen/setup.c
> --- a/xen/arch/ia64/linux-xen/setup.c	Tue Jan 30 16:09:16 2007 +0000
> +++ b/xen/arch/ia64/linux-xen/setup.c	Tue Jan 30 16:14:16 2007 +0000
> @@ -550,7 +550,7 @@ show_cpuinfo (struct seq_file *m, void *
>  	switch (c->family) {
>  	      case 0x07:	memcpy(family, "Itanium", 8); break;
>  	      case 0x1f:	memcpy(family, "Itanium 2", 10); break;
> -	      default:		sprintf(family, "%u", c->family); break;
> +	      default:		snprintf(family, sizeof(family), "%u", c->family); break;
>  	}

   What's the purpose of all this "cleanup"?  This is just munging files
that we're leveraging from Linux, making updating them later on more
difficult.  And these really should have been submitted via the
xen-ia64-devel list.

	Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.