All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] Celleb: improve htab lock
Date: Fri, 09 Feb 2007 09:30:08 +1100	[thread overview]
Message-ID: <1170973808.2620.379.camel@localhost.localdomain> (raw)
In-Reply-To: <20070208202802.GA2579@lst.de>


> But I think the issue here is that we don't want to disable irqs because
> we want to protect against IRQ context, but rather because the
> hypervisor expects it.

No not really. The problem here is that we get a spinlock re-entrancy if
we don't disable IRQs so it's a typical textbook usage of
spin_lock_irqsave.

The problem is that if you don't disable IRQs, you can take an irq or a
decrementer exception causing some code to hit vmalloc or ioremap space
which might cause a hash fault, thus you may deadlock on the spinlock
via htab_insert.

Ben.

  parent reply	other threads:[~2007-02-08 22:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  6:18 [PATCH] Celleb: improve htab lock Ishizaki Kou
2007-02-08  6:51 ` Arnd Bergmann
2007-02-08 20:28   ` Christoph Hellwig
2007-02-08 20:43     ` Arnd Bergmann
2007-02-08 22:32       ` Benjamin Herrenschmidt
2007-02-09  6:44         ` Akira Iguchi
2007-02-08 22:30     ` Benjamin Herrenschmidt [this message]
2007-02-08 21:20   ` Benjamin Herrenschmidt
     [not found] <200702090643.l196hHDv006227@toshiba.co.jp>
2007-02-09  6:52 ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2007-02-09  7:53 Akira Iguchi
2007-02-09  9:19 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1170973808.2620.379.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=arnd@arndb.de \
    --cc=hch@lst.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.