From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423224AbXBIW0T (ORCPT ); Fri, 9 Feb 2007 17:26:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423343AbXBIW0T (ORCPT ); Fri, 9 Feb 2007 17:26:19 -0500 Received: from nigel.suspend2.net ([203.171.70.205]:45066 "EHLO nigel.suspend2.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423224AbXBIW0S (ORCPT ); Fri, 9 Feb 2007 17:26:18 -0500 Subject: Re: NAK new drivers without proper power management? From: Nigel Cunningham Reply-To: nigel@nigel.suspend2.net To: Arjan van de Ven Cc: LKML In-Reply-To: <1171059433.8675.195.camel@laptopd505.fenrus.org> References: <1171058269.1484.64.camel@nigel.suspend2.net> <1171059433.8675.195.camel@laptopd505.fenrus.org> Content-Type: text/plain Date: Sat, 10 Feb 2007 09:26:08 +1100 Message-Id: <1171059968.1484.90.camel@nigel.suspend2.net> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi. On Fri, 2007-02-09 at 23:17 +0100, Arjan van de Ven wrote: > On Sat, 2007-02-10 at 08:57 +1100, Nigel Cunningham wrote: > > Hi. > > > > I don't think this is already done (feel free to correct me if I'm > > wrong).. > > > > Can we start to NAK new drivers that don't have proper power management > > implemented? There really is no excuse for writing a new driver and not > > putting .suspend and .resume methods in anymore, is there? > > > to a large degree, a device driver that doesn't suspend is better than > no device driver at all, right? I'm not sure it is. It only makes more work for everyone else: We have to help people figure out what causes their computer to fail to resume (which can take quite a while), then get them them complain to driver author, and the driver author has to submit patches to fix it. All of this is avoided if they'll just do it right in the first place. > now.. if you want to make the core warn about it, that's very fair That's probably a good idea too, since I'm only suggesting this for new drivers. Regards, Nigel