From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([66.187.233.31]:54895 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbXBMUeR (ORCPT ); Tue, 13 Feb 2007 15:34:17 -0500 Subject: Re: [PATCH] prism54: correct assignment of DOT1XENABLE in WE-19 codepaths From: Dan Williams To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com In-Reply-To: <1171394427.10344.112.camel@johannes.berg> References: <1171393222.5329.11.camel@localhost.localdomain> <1171393331.10344.106.camel@johannes.berg> <1171394306.5329.24.camel@localhost.localdomain> <1171394427.10344.112.camel@johannes.berg> Content-Type: text/plain Date: Tue, 13 Feb 2007 15:36:39 -0500 Message-Id: <1171398999.5329.39.camel@localhost.localdomain> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2007-02-13 at 20:20 +0100, Johannes Berg wrote: > On Tue, 2007-02-13 at 14:18 -0500, Dan Williams wrote: > > On Tue, 2007-02-13 at 20:02 +0100, Johannes Berg wrote: > > > On Tue, 2007-02-13 at 14:00 -0500, Dan Williams wrote: > > > > Correct assignment of DOT1XENABLE in WE-19 codepaths. > > > > RX_UNENCRYPTED_EAPOL = 1 really means setting DOT1XENABLE _off_, and > > > > vice versa. The original WE-19 patch erroneously reversed that. This > > > > patch fixes association with unencrypted and WEP networks when using > > > > wpa_supplicant. > > > > > > > > It also adds two missing break statements that, left out, could result > > > > in incorrect card configuration. > > > > > > > > Please commit to both development and stable branches. > > > > ^^^^^ > > > > Right; applicable to anything after _and_ including 2.6.19, which is > > when I think the WE-19 patch landed. > > But I think John will take it to mean to apply it to wireless-dev and > wireless-2.6 so you should send it to stable@kernel.org Aha; ok. Will do. Dan