From: Pavel Roskin <proski@gnu.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] d80211: fix incorrect hw.priv setting in ieee80211_alloc_hw()
Date: Sun, 18 Feb 2007 16:54:45 -0500 [thread overview]
Message-ID: <1171835685.2201.4.camel@dv> (raw)
In-Reply-To: <1171707397.3487.5.camel@johannes.berg>
On Sat, 2007-02-17 at 11:16 +0100, Johannes Berg wrote:
> On Sat, 2007-02-17 at 02:42 -0500, Pavel Roskin wrote:
> > hw.priv is set twice, and the second time it's set incorrectly to an
> > area relative to the master device, which wasn't allocated for private
> > data.
>
> Yeah, this is obviously correct. Guess I was drinking when I did these
> patches. I really wonder why I never saw any of your problems though, I
> do have bcm43xx running here. Not that the driver actually does anything
> for me, it always refuses to associate...
Oh, and by the way, wouldn't it be reasonable to have an inline function
to calculate the pointer to the priv area instead of having an actual
field for the pointer?
Also, it looks like we need a generic macro for aligning sizes.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2007-02-18 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-17 7:42 [PATCH] d80211: fix incorrect hw.priv setting in ieee80211_alloc_hw() Pavel Roskin
2007-02-17 10:16 ` Johannes Berg
2007-02-18 21:54 ` Pavel Roskin [this message]
2007-02-19 6:33 ` Johannes Berg
2007-02-19 13:43 ` Pavel Roskin
2007-02-19 14:18 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171835685.2201.4.camel@dv \
--to=proski@gnu.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.