All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Antill <james.antill@redhat.com>
To: Steve G <linux_4ever@yahoo.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>, SE Linux <selinux@tycho.nsa.gov>
Subject: Re: libselinux patch
Date: Thu, 22 Feb 2007 09:45:04 -0500	[thread overview]
Message-ID: <1172155504.23774.84.camel@code.and.org> (raw)
In-Reply-To: <305125.10227.qm@web51504.mail.yahoo.com>

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

On Thu, 2007-02-22 at 05:46 -0800, Steve G wrote:
> >
> >- Why u_int32_t instead of just long (per the statfs man page)?
> 
> SELINUX_MAGIC is 0xf97cff8c and the upper bit is 1, so it gets sign extended in
> 64 bit kernels. Then the direct comparison fails.

 Why not just have the define as:

#define SELINUX_MAGIC 0xf97cff8cU

-- 
James Antill - <james.antill@redhat.com>
setsockopt(fd, IPPROTO_TCP, TCP_CONGESTION, ...);
setsockopt(fd, IPPROTO_TCP, TCP_DEFER_ACCEPT, ...);
setsockopt(fd, SOL_SOCKET,  SO_ATTACH_FILTER, ...);


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2007-02-22 14:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-20 14:31 libselinux patch Daniel J Walsh
2007-02-20 15:05 ` Steve G
2007-02-20 15:06   ` Stephen Smalley
2007-02-21 13:12     ` Steve G
2007-02-21 13:20       ` Stephen Smalley
2007-02-21 13:37         ` Steve G
2007-02-21 13:42           ` Stephen Smalley
2007-02-21 14:03             ` Steve G
2007-02-21 18:26               ` Steve G
2007-02-22 12:34                 ` Stephen Smalley
2007-02-22 13:46                   ` Steve G
2007-02-22 14:10                     ` Stephen Smalley
2007-02-22 15:48                       ` Steve G
2007-02-23 20:45                         ` Stephen Smalley
2007-02-26 16:40                           ` Steve G
2007-02-27 15:15                             ` Stephen Smalley
2007-02-27 15:58                               ` Christopher J. PeBenito
2007-02-22 14:45                     ` James Antill [this message]
2007-02-21 14:47           ` Stefanos Harhalakis
2007-02-21 17:21 ` Stephen Smalley
  -- strict thread matches above, loose matches on Subject: below --
2007-04-05 17:25 Daniel J Walsh
2007-04-05 17:44 ` Stephen Smalley
2007-04-05 21:00   ` Daniel J Walsh
2007-04-09 14:17     ` Stephen Smalley
2007-04-09 15:12       ` Daniel J Walsh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1172155504.23774.84.camel@code.and.org \
    --to=james.antill@redhat.com \
    --cc=linux_4ever@yahoo.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.