From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] fix an IA64 MCA kdump bug in kdump_init_notifier
Date: Tue, 20 Mar 2007 02:53:51 +0000 [thread overview]
Message-ID: <11723.1174359231@kao2.melbourne.sgi.com> (raw)
In-Reply-To: <45FF431C.1040607@sgi.com>
Horms (on Tue, 20 Mar 2007 11:34:28 +0900) wrote:
>On Mon, Mar 19, 2007 at 07:12:44PM -0700, Jay Lan wrote:
>> Since DIE_INIT_SLAVE_ENTER is a non-zero value, thus "nd->sos->rv_rc
>> =1" is always evaluated. The kdump kernel aborted because nd->sos
>> is NULL in (at least some) MCA cases.
>
>I think that your fix below does correct a problem,
>in that "|| DIE_INIT_SLAVE_ENTER" appears to be quite bogus.
>But if you are worried about nd->sos being NULL, is it worth checking
>for that explicitly. Or will it always be non-NULL with the code below?
nd->sos is only (and always) defined for the MCA/INIT SAL to OS
handlers. nd->sos is NULL for events such as MCA rendezvous interrupt,
since that event runs on the normal kernel stack.
next prev parent reply other threads:[~2007-03-20 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 2:12 [PATCH] fix an IA64 MCA kdump bug in kdump_init_notifier Jay Lan
2007-03-20 2:34 ` Horms
2007-03-20 2:53 ` Keith Owens [this message]
2007-03-20 4:29 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11723.1174359231@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.