From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: shpedoikal@gmail.com, netdev@vger.kernel.org
Subject: Re: xfrm_add_sa_expire return codes
Date: Mon, 26 Feb 2007 19:31:06 -0500 [thread overview]
Message-ID: <1172536266.4847.4.camel@localhost> (raw)
In-Reply-To: <20070226.144854.102122743.davem@davemloft.net>
On Mon, 2007-26-02 at 14:48 -0800, David Miller wrote:
> Indeed, and the tabbing on the first "err = " assignment should
> be a clue that some mistake might have been added.
>
> It looks like the code has been like that from day one, I wonder
> how Jamal tested this stuff :-)
>
I am asking myself the same question staring at that;->
Let me look at the test code tommorow and get back to you. I know my
test was "passing" ;->
> I'm going to assume the intended logic, and fix it like this.
> Jamal?
>
Looks good - thanks Dave.
cheers,
jamal
prev parent reply other threads:[~2007-02-27 0:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <499d6ed30702261426r107fb555hd621418376f5c61c@mail.gmail.com>
2007-02-26 22:48 ` xfrm_add_sa_expire return codes David Miller
2007-02-27 0:31 ` jamal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172536266.4847.4.camel@localhost \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shpedoikal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.