All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nigel Cunningham <nigel@nigel.suspend2.net>
To: Johan Henriksson <jhn98032@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Radeon xpress 200m and radeonfb kinda work
Date: Thu, 08 Mar 2007 09:39:27 +1100	[thread overview]
Message-ID: <1173307167.3219.111.camel@nigel.suspend2.net> (raw)
In-Reply-To: <45ECB2D0.3080205@telia.com>

Hi.

On Tue, 2007-03-06 at 01:16 +0100, Johan Henriksson wrote:
> Hi!
> 
> I have gotten the radeon xpress 200m (the version without dedicated
> vmem)
>  to work with radeonfb.
> The attached patch (against linux-2.6.20.1) works for me.
> Since I don't have any docs for the card I am unsure if the patch is 
> 100% correct.
> Can someone else with a 200m try it out?
> (I have tested it by enabling  fbcon and radeonfb in the kernel  and
>  added "video=radeonfb" to lilo. This gave me a nice 1280x800
> console :) )
> 
> /Johan Henriksson
> 
> Please CC, I'm not on the list.
> 
> @@ -2329,7 +2332,7 @@ static int __devinit radeonfb_pci_regist
>  		/* -2 is special: means  ON on mobility chips and do not
>  		 * change on others
>  		 */
> -		radeonfb_pm_init(rinfo, rinfo->is_mobility ? 1 : -1, ignore_devlist, force_sleep);
> +		radeonfb_pm_init(rinfo, -1,ignore_devlist, force_sleep);//rinfo->is_mobility ? 1 : -1);

That looks like it might break !200M. Maybe something line
rinfo->is_mobility && !rinfo->rs480 (with additional modifications to
define an rs480, of course) - or a more generic name indicating why the
rs480 is different?

Regards,

Nigel


  parent reply	other threads:[~2007-03-07 22:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-06  0:16 Radeon xpress 200m and radeonfb kinda work Johan Henriksson
2007-03-07 16:43 ` Chuck Ebbert
2007-03-07 20:58   ` johan henriksson
2007-03-08 16:00     ` Chuck Ebbert
2007-03-08 19:24       ` [patch 2.6.20-1] radeonfb: Add support for Radeon xpress 200m johan henriksson
2007-03-09 13:00         ` Benjamin Herrenschmidt
2007-03-09 19:57           ` johan henriksson
2007-03-07 22:39 ` Nigel Cunningham [this message]
2007-03-07 22:59   ` Radeon xpress 200m and radeonfb kinda work johan henriksson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1173307167.3219.111.camel@nigel.suspend2.net \
    --to=nigel@nigel.suspend2.net \
    --cc=jhn98032@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.