From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Williamson <alex.williamson@hp.com>
Subject: Re: [Xense-devel][PATCH][XSM][1/4] Xen Security Modules
	Patch
Date: Thu, 08 Mar 2007 08:59:07 -0700
Message-ID: <1173369547.5941.212.camel@bling>
References: <1173367723.11144.29.camel@moss-walleye.epoch.ncsc.mil>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1173367723.11144.29.camel@moss-walleye.epoch.ncsc.mil>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "George S. Coker, II" <gscoker@alpha.ncsc.mil>
Cc: xen-devel@lists.xensource.com, xense-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2007-03-08 at 10:28 -0500, George S. Coker, II wrote:
> +    /*
> +     * Try all modules and see whichever could be the binary policy.
> +     * Adjust the initrdidx if module[1] is the binary policy.
> +     */
> +    for (i = mbi->mods_count-1; i >= 1; i--) {
> +#if defined(__i386__)
> +        _policy_start = (u32 *)(initial_images_start + (mod[i].mod_start-mod[0].mod_start));
> +#elif defined(__x86_64__)
> +        _policy_start = __va(initial_images_start + (mod[i].mod_start-mod[0].mod_start));
> +#else
> +#error Architecture unsupported by XSM
> +#endif

   This is unacceptable, please make it fail gracefully on non-x86.
Thanks,

	Alex
 
-- 
Alex Williamson                             HP Open Source & Linux Org.