All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put)
Date: Tue, 13 Mar 2007 09:13:00 +1100	[thread overview]
Message-ID: <1173737580.10618.7.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.58.0703120652100.19670@shell2.speakeasy.net>

Hi Trent,

	Patch looks good, just one comment:

On Mon, 2007-03-12 at 07:07 -0700, Trent Piepho wrote:
> +       use = already_uses(a, b);
> +       if (!use) {
> +           printk(KERN_ERR "module %s trying to un-use a module, %s, which "
> +                  "it is not using", a->name, b->name);
> +            return 0;
> +       }

s/return 0/BUG()/.  This is potentially quite a nasty bug.

Thanks!
Rusty.


  reply	other threads:[~2007-03-12 22:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-10  4:31 [RFC PATCH 1/3] Add ability to keep track of callers of symbol_(get|put) Mauro Carvalho Chehab
2007-03-11  2:29 ` Rusty Russell
2007-03-11  8:09 ` Andrew Morton
2007-03-11 21:12   ` Oleg Verych
2007-03-12 14:07   ` Trent Piepho
2007-03-12 22:13     ` Rusty Russell [this message]
2007-03-13  6:33       ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1173737580.10618.7.camel@localhost.localdomain \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.