From: Rusty Russell <rusty@rustcorp.com.au>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: "Robert P. J. Day" <rpjday@mindspring.com>,
Jan Beulich <jbeulich@novell.com>, Andi Kleen <ak@muc.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] BUILD_BUG_ON_ZERO -> BUILD_BUG_OR_ZERO
Date: Tue, 13 Mar 2007 09:25:03 +1100 [thread overview]
Message-ID: <1173738303.10618.15.camel@localhost.localdomain> (raw)
In-Reply-To: <45F5604E.5020400@s5r6.in-berlin.de>
On Mon, 2007-03-12 at 15:14 +0100, Stefan Richter wrote:
> Robert P. J. Day wrote:
> > On Mon, 12 Mar 2007, Stefan Richter wrote:
> >> Rusty Russell wrote:
> >> > OTOH, BUILD_BUG_OR_ZERO says what happens: either it's a build bug, or
> >> > it's zero.
> >>
> >> What about ZERO_UNLESS_BUILD_BUG_ON(e)? It's long though...
> >
> > how often is this going to be used? it's not like the tree is
> > currently awash in calls to BUILD_BUG_ON_ZERO as it is.
>
> Most of the time it will hidden as a macro-in-a-macro, like in
> ARRAY_SIZE(). So the length of the name doesn't matter much. But then,
> the _name_ itself doesn't matter much because authors of public macros
> are the primary user group, not John Driverhacker.
Well, there's a four line comment above it, so *someone* thought it
worth documenting. Even if the new name isn't great, the old name is
actively misleading. That's a 13, and we could be a 4.
http://ozlabs.org/~rusty/ols-2003-keynote/img52.html
Cheers,
Rusty.
next prev parent reply other threads:[~2007-03-12 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 23:28 [PATCH] BUILD_BUG_ON_ZERO -> BUILD_BUG_OR_ZERO Rusty Russell
2007-03-12 8:23 ` Jan Beulich
2007-03-12 8:39 ` Jan Engelhardt
2007-03-12 9:25 ` Rusty Russell
2007-03-12 11:41 ` Stefan Richter
2007-03-12 11:49 ` Robert P. J. Day
2007-03-12 14:14 ` Stefan Richter
2007-03-12 22:25 ` Rusty Russell [this message]
2007-03-12 9:42 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1173738303.10618.15.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=ak@muc.de \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.