From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1HV95y-0007j8-5T for mharc-grub-devel@gnu.org; Sat, 24 Mar 2007 12:27:58 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HV95x-0007g6-8g for grub-devel@gnu.org; Sat, 24 Mar 2007 12:27:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HV95t-0007Sh-QS for grub-devel@gnu.org; Sat, 24 Mar 2007 12:27:56 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HV95t-0007SS-Mp for grub-devel@gnu.org; Sat, 24 Mar 2007 11:27:53 -0500 Received: from pop-tawny.atl.sa.earthlink.net ([207.69.195.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HV93r-0007BE-2y for grub-devel@gnu.org; Sat, 24 Mar 2007 12:25:47 -0400 Received: from user-0vvdf2d.cable.mindspring.com ([63.246.188.77] helo=[192.168.0.2]) by pop-tawny.atl.sa.earthlink.net with esmtp (Exim 3.36 #1) id 1HV93q-0004pp-00 for grub-devel@gnu.org; Sat, 24 Mar 2007 12:25:46 -0400 From: Hollis Blanchard To: The development of GRUB 2 In-Reply-To: <000001c76e2c$a9b694c0$030010ac@temjin> References: <000001c76e2c$a9b694c0$030010ac@temjin> Content-Type: text/plain; charset=utf-8 Date: Sat, 24 Mar 2007 11:25:45 -0500 Message-Id: <1174753545.602.26.camel@diesel> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-1.fc6) Content-Transfer-Encoding: quoted-printable X-detected-kernel: Solaris 8 (1) Subject: Re: I write a patch for Japanese NEC i386 old computers. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2007 16:27:57 -0000 On Sun, 2007-03-25 at 00:53 +0900, =E5=B0=8F=E9=96=A2 =E4=B8=80=E5=BF=97 wr= ote: > Hello, all. >=20 > I write a patch for GRUB 1.95. this is able to run GRUB2 under NEC PC-980= 0 > series. (NEC PC-9800 is Japanese i386 computer, but its hardware design i= s different > with PC.) >=20 > Attach file: grub-1.95-nec98.diff.gz (113Kbytes) Thanks for your hard work! You seem to have copied many files from i386/pc to i386/nec. A better approach would be to share them directly, for example by moving them to the i386 directory. Could you separate your changes to common code (e.g. the code movement above, get_diskinfo, etc) and post those patches separately? That way we don't have a 650KB (!!!) patch to review. The code movement patch should just be a list of old location -> new location (that way it doesn't take up much space at all :) . -Hollis