Re: [PATCH 1/1] Fix various memory leaks

[Steve Grubb <sgrubb@redhat.com>]

On Wednesday, May 12, 2021 6:35:54 PM EDT Bastien Nocera wrote:
> On Wed, 2021-05-12 at 13:39 -0400, Steve Grubb wrote:
> > diff --git a/obexd/plugins/filesystem.c b/obexd/plugins/filesystem.c
> > index 09bff8ad0..44e3cf3d2 100644
> > --- a/obexd/plugins/filesystem.c
> > +++ b/obexd/plugins/filesystem.c
> > @@ -415,7 +415,7 @@ static void *capability_open(const char *name,
> > int oflag, mode_t mode,
> >                         goto fail;
> >                 }
> >  
> > -               object->buffer = g_string_new(buf);
> > +               object->buffer = buf;
> >  
> >                 if (size)
> >                         *size = object->buffer->len;
> 
> Pretty certain this is wrong. 

Yeah, now that you mention it...that is a GString object. I guess we 
g_free(buf) right after the g_string_new(). Should I resend just that one 
patch or do I need to regenerate all 7 emails?

-Steve