All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@hp.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] pciback: restore PCI BARs on D3->D0 transition
Date: Mon, 26 Mar 2007 14:23:13 -0600	[thread overview]
Message-ID: <1174940593.5781.7.camel@lappy> (raw)
In-Reply-To: <1174937343.20923.38.camel@bling>

On Mon, 2007-03-26 at 13:29 -0600, Alex Williamson wrote:
> However, we obviously can't expect PCI devices to work without their
> BARs properly programmed.  The patch below adds a call to
> pci_restore_bars() as a workaround until we can figure out why the PCI
> code doesn't do this for us.  Thanks,

   From what I can gather, it seems when a driver induces a transition
to D3, its expected to use pci_save_state() and pci_restore_state().  I
don't think we necessarily need to go to that extent for pciback, but it
does appear to be pciback's responsibility to restore some state on the
card when transitioning out of D3, since it is effectively the driver
for the device.  So, I think the pci_restore_bars() call and the patch I
sent previously are correct.  Thanks,

	Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.

  reply	other threads:[~2007-03-26 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26 19:29 [PATCH] pciback: restore PCI BARs on D3->D0 transition Alex Williamson
2007-03-26 20:23 ` Alex Williamson [this message]
2007-03-27  0:32   ` Keir Fraser
2007-04-03 15:52     ` Chris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1174940593.5781.7.camel@lappy \
    --to=alex.williamson@hp.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.