From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, Jouni Malinen <j@w1.fi>
Subject: Re: WPA/RSN information in cfg80211?
Date: Wed, 28 Mar 2007 10:47:13 -0400 [thread overview]
Message-ID: <1175093233.6907.5.camel@localhost.localdomain> (raw)
In-Reply-To: <1175034846.5151.20.camel@johannes.berg>
On Wed, 2007-03-28 at 00:34 +0200, Johannes Berg wrote:
> Looking through wpa_supplicant and then through the kernel I notice that
> we currently in the kernel special-case some things in SIOCSIWAUTH, for
> example IW_AUTH_WPA_VERSION is ignored since we rely on the IE that wpa
> supplicant gave us.
>
> Apart from how wrong I think this is (we shouldn't be allowing a setting
> we can't do, we need to return some error code and wpa_supplicant should
> sort it out) I also found only one occurrence in prism54 where the
> parameters are actually not ignored. Is that driver fully replaced by
> p54?
>
> Is there any point in supporting these at all? Does the Libertas 8388
> requires the settings as well instead of just the IE to include?
Libertas driver just uses the WPA1/2 selector stuff internally to figure
out what BSS to associate with; I don't think it's actually needed and
it could certainly be scraped from the IE that the user sets.
For the prism54 driver, I was just translating what the
HOSTAP/PRISM2_IOCTL things did. I never quite understood why there was
a WPA_VERSION selector in IWAUTH, because I thought the IE did that for
us :)
Dan
> I'm inclined to just require userspace to put both the IE and the
> individual settings into the relevant nl80211 messages, but then we
> might just as well piece the IE together from those settings, no?
>
> johannes
next prev parent reply other threads:[~2007-03-28 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 22:34 WPA/RSN information in cfg80211? Johannes Berg
2007-03-28 9:33 ` Mark Powell
2007-03-28 9:47 ` Johannes Berg
2007-03-28 10:04 ` Mark Powell
2007-03-28 10:24 ` Johannes Berg
2007-03-28 14:47 ` Dan Williams [this message]
2007-03-28 19:00 ` Jouni Malinen
2007-03-29 11:12 ` Johannes Berg
2007-03-29 15:44 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175093233.6907.5.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.