From: Pavel Roskin <proski@gnu.org>
To: andy@warmcat.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/5] Meddled with by Andy Green since signed-off: made it apply to current wireless-dev, took out comments for radiotap types not in current wireless-dev
Date: Thu, 29 Mar 2007 15:12:39 -0400 [thread overview]
Message-ID: <1175195559.12052.14.camel@dv> (raw)
In-Reply-To: <20070329133123.323900095@warmcat.com>
On Thu, 2007-03-29 at 14:31 +0100, andy@warmcat.com wrote:
> plain text document attachment
> (mac80211-sparse-annotate-radiotap-header-pavel-roskin.diff)
> Document that all fields must be little endian. Use annotated types
> even in the comments. Consistently use shorter type names (u8, s8).
> Realign the comments.
I don't know what it means, but I think wireless-dev should just copy
include/net/ieee80211_radiotap.h from wireless-2.6. The later has more
fields, and it turns out they are approved by David Young, the radiotap
maintainer.
There is no reason mac80211 would need to change that file.
> *
> - * IEEE80211_RADIOTAP_FCS u32 data
> + * IEEE80211_RADIOTAP_FCS __le32 data
> *
> * FCS from frame in network byte order.
I sent a patch yesterday that removes this part altogether.
I'm fine with this patch, I'm just saying that adjusting the patch is
more work than copying the file.
--
Regards,
Pavel Roskin
next parent reply other threads:[~2007-03-29 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070329133114.569947199@warmcat.com>
[not found] ` <20070329133123.323900095@warmcat.com>
2007-03-29 19:12 ` Pavel Roskin [this message]
2007-03-29 19:28 ` [PATCH 1/5] Meddled with by Andy Green since signed-off: made it apply to current wireless-dev, took out comments for radiotap types not in current wireless-dev Andy Green
2007-03-29 22:00 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175195559.12052.14.camel@dv \
--to=proski@gnu.org \
--cc=andy@warmcat.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.