From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, David Woodhouse <dwmw2@infradead.org>,
cbe-oss-dev@ozlabs.org
Subject: Re: [Cbe-oss-dev] [PATCH] Implement check_legacy_ioport() on PS3
Date: Fri, 30 Mar 2007 11:45:37 +1000 [thread overview]
Message-ID: <1175219137.28116.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20070330014542.GA28342@lixom.net>
On Thu, 2007-03-29 at 20:45 -0500, Olof Johansson wrote:
> On Fri, Mar 30, 2007 at 01:02:52AM +0100, David Woodhouse wrote:
> > It doesn't like it when we poke at legacy I/O ports like the i8042. We
> > should probably change the _default_ to return -ENODEV, and let any
> > strange platform which wants to allow unfettered access provide its own
> > function for that.
>
> I ran into the very same thing earlier myself and had exactly the same
> idea. However, it turned out then that it would have meant adding more
> cases of ioport being allowed than it would have removed the opposite. It
> might have changed since then. Either way it's annoying.
I was thinking that we could have one single helper shared by most
platforms who allow that legacy ISA crap which checks the device-tree
for known ISA devices. That would cover PREP, CHRP and pSeries at
least...
Ben.
next prev parent reply other threads:[~2007-03-30 1:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 0:02 [PATCH] Implement check_legacy_ioport() on PS3 David Woodhouse
2007-03-30 1:45 ` Olof Johansson
2007-03-30 1:43 ` David Woodhouse
2007-03-30 1:43 ` [Cbe-oss-dev] " Michael Ellerman
2007-03-30 1:47 ` Benjamin Herrenschmidt
2007-03-30 1:49 ` David Woodhouse
2007-03-30 1:45 ` Benjamin Herrenschmidt [this message]
2007-03-30 13:44 ` Segher Boessenkool
2007-04-06 21:32 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175219137.28116.2.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.