All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: dragoran dragoran <drago01@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org,
	John Linville <linville@redhat.com>, Jiri Benc <jbenc@suse.cz>
Subject: Re: mac80211 does not support WPA when used with wext
Date: Sat, 31 Mar 2007 20:50:24 -0400	[thread overview]
Message-ID: <1175388624.10282.0.camel@localhost.localdomain> (raw)
In-Reply-To: <200703311700.52792.flamingice@sourmilk.net>

On Sat, 2007-03-31 at 17:00 -0400, Michael Wu wrote:
> On Saturday 31 March 2007 15:56, dragoran dragoran wrote:
> > also networkmanager and hal think that the card only supports wep...
> > thx for the patch...
> > does it adress this issues?
> No, this has nothing to do with that. The following patch should address that 
> issue, but my copy of networkmanager already does WPA fine so I can't say for 
> sure whether it will help or not. A quick look through the networkmanager 
> code seems to suggest this will work.

Correct; NM won't allow WPA unless the driver explicitly advertises
support for it.

Acked-by: Dan Williams <dcbw@redhat.com>

> --
> 
> mac80211: set enc_capa
> 
> From: Michael Wu <flamingice@sourmilk.net>
> 
> Update we_version_source and set enc_capa in iw_range.
> 
> Signed-off-by: Michael Wu <flamingice@sourmilk.net>
> ---
> 
>  net/mac80211/ieee80211_ioctl.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/ieee80211_ioctl.c b/net/mac80211/ieee80211_ioctl.c
> index b28e794..d139d97 100644
> --- a/net/mac80211/ieee80211_ioctl.c
> +++ b/net/mac80211/ieee80211_ioctl.c
> @@ -1583,7 +1583,7 @@ static int ieee80211_ioctl_giwrange(struct net_device 
> *dev,
>  	memset(range, 0, sizeof(struct iw_range));
>  
>  	range->we_version_compiled = WIRELESS_EXT;
> -	range->we_version_source = 14;
> +	range->we_version_source = 21;
>  	range->retry_capa = IW_RETRY_LIMIT;
>  	range->retry_flags = IW_RETRY_LIMIT;
>  	range->min_retry = 0;
> @@ -1603,6 +1603,9 @@ static int ieee80211_ioctl_giwrange(struct net_device 
> *dev,
>  	range->avg_qual.noise = 0;
>  	range->avg_qual.updated = local->wstats_flags;
>  
> +	range->enc_capa = IW_ENC_CAPA_WPA | IW_ENC_CAPA_WPA2 |
> +			  IW_ENC_CAPA_CIPHER_TKIP | IW_ENC_CAPA_CIPHER_CCMP;
> +
>  	return 0;
>  }
>  


  reply	other threads:[~2007-04-01  0:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-31  9:36 mac80211 does not support WPA when used with wext dragoran
2007-03-31 10:00 ` Johannes Berg
2007-03-31 10:11   ` dragoran
2007-03-31 11:19   ` dragoran
2007-03-31 16:37     ` Michael Buesch
2007-03-31 16:39       ` Michael Buesch
2007-03-31 17:57       ` Dan Williams
2007-03-31 17:48   ` Dan Williams
2007-03-31 17:59     ` Jouni Malinen
2007-03-31 18:09     ` Larry Finger
2007-03-31 19:03     ` Michael Wu
     [not found]       ` <f6ca9fed0703311256m1b14ec35p836a62de532dd804@mail.gmail.com>
2007-03-31 21:00         ` Michael Wu
2007-04-01  0:50           ` Dan Williams [this message]
2007-04-02  3:50             ` WPA does not connect to bcm43xx-mac80211 when using NetworkManager Larry Finger
2007-04-02  4:12               ` Dan Williams
2007-04-03 14:26                 ` Larry Finger
2007-04-02  5:26               ` Michael Wu
2007-04-01  8:18           ` mac80211 does not support WPA when used with wext Johannes Berg
     [not found]           ` <f6ca9fed0704081445u5536e596m4ca4caeb44f7f87@mail.gmail.com>
2007-04-08 21:54             ` Michael Wu
     [not found]               ` <f6ca9fed0704081527j641a4ecat44151e107cab7342@mail.gmail.com>
2007-04-10  7:13                 ` dragoran
2007-04-10 12:25                   ` Dan Williams
2007-04-10 14:34                     ` dragoran dragoran
2007-04-10 14:39                   ` Larry Finger
2007-04-10 14:44                     ` dragoran dragoran
2007-04-01  0:55       ` Dan Williams
2007-04-01  1:21         ` Michael Wu
2007-04-01  4:51           ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175388624.10282.0.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=drago01@gmail.com \
    --cc=flamingice@sourmilk.net \
    --cc=jbenc@suse.cz \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.