From: George Zhang <georgezhang@vmware.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: VMCI: queue pairs implementation.
Date: Thu, 10 Jan 2013 19:36:35 +0000 [thread overview]
Message-ID: <117563178.6921475.1357846595066.JavaMail.root@vmware.com> (raw)
In-Reply-To: <20130110193238.GB17997@elgon.mountain>
Dan,
And will fix this too,
Thanks so much,
george
----- Original Message -----
> From: "Dan Carpenter" <dan.carpenter@oracle.com>
> To: georgezhang@vmware.com
> Cc: kernel-janitors@vger.kernel.org, kbuild@01.org
> Sent: Thursday, January 10, 2013 11:32:39 AM
> Subject: re: VMCI: queue pairs implementation.
>
> Hello George Zhang,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 06164d2b72aa: "VMCI: queue pairs implementation." from Jan
> 8, 2013, leads to the following Smatch complaint:
>
> drivers/misc/vmw_vmci/vmci_queue_pair.c:3356 vmci_qpair_dequev()
> warn: variable dereferenced before check 'qpair' (see line 3354)
>
> drivers/misc/vmw_vmci/vmci_queue_pair.c
> 3353
> 3354 qp_lock(qpair);
> ^^^^^^
> dereference.
>
> 3355
> 3356 if (!qpair || !iov)
> ^^^^^
> test.
>
> 3357 return VMCI_ERROR_INVALID_ARGS;
> 3358
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2013-01-10 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 19:32 VMCI: queue pairs implementation Dan Carpenter
2013-01-10 19:36 ` George Zhang [this message]
2014-01-30 11:51 ` Dan Carpenter
2014-01-30 11:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=117563178.6921475.1357846595066.JavaMail.root@vmware.com \
--to=georgezhang@vmware.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.