From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: "John Anthony Kazos Jr." <jakj@j-a-k-j.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: (un)lock_kernel() ?
Date: Wed, 04 Apr 2007 10:36:42 -0500 [thread overview]
Message-ID: <1175701002.6489.4.camel@shaggy> (raw)
In-Reply-To: <alpine.DEB.0.83.0704040853450.28216@sigma.j-a-k-j.com>
On Wed, 2007-04-04 at 08:57 -0400, John Anthony Kazos Jr. wrote:
> Why does ext4_fill_super release the BKL on entry and take it on both
> normal and abnormal exit? As far as I can see, ext4_fill_super is called
> by get_sb_bdev, which calls the ->get_sb method without the BKL, and
> ext4_get_sb calls get_sb_bdev without the BKL. And the ext2 code does not
> touch the BKL in ext2_fill_super.
>
> Is the VFS code going to be changed somewhere in the future and it's being
> anticipated, or is this a bug?
According to Documentation/filesystems/Locking, ->get_sb() is called
with the BKL held, but looking through the code, I'm not able to find
where it is being taken.
Shaggy
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2007-04-04 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 12:57 (un)lock_kernel() ? John Anthony Kazos Jr.
2007-04-04 15:36 ` Dave Kleikamp [this message]
2007-04-04 16:52 ` John Anthony Kazos Jr.
2007-04-10 16:03 ` Ming Zhang
2007-04-10 16:10 ` Dave Kleikamp
2007-04-10 16:55 ` Ming Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1175701002.6489.4.camel@shaggy \
--to=shaggy@linux.vnet.ibm.com \
--cc=jakj@j-a-k-j.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.